DAOS-18727 rsvc: Fix add_replicas_s error handling (#18536)#18607
Draft
liw wants to merge 1 commit into
Draft
Conversation
During a PS reconfiguration, inside ds_rsvc_add_replicas_s, if the rdb_modify_replicas call returns -DER_NOTLEADER, the new replica may have been added to the local membership, but ds_rsvc_add_replicas_s destroys it. This missing member may render the PS unavailable, especially after a rdb_dictate call. This patch changes the error handling to destroy the new replica only if it hasn't been added the local membership. (We add it locally before adding it remotely.) Signed-off-by: Li Wei <liwei@hpe.com>
|
Ticket title is './recovery/pool_list_consolidation.py:PoolListConsolidationTest.test_lost_majority_ps_replicas - rdb-pool are recovered, three out of four ranks should have rdb-pool' |
github-actions
Bot
added
the
priority
liw
added
the
clean-cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a PS reconfiguration, inside ds_rsvc_add_replicas_s, if the rdb_modify_replicas call returns -DER_NOTLEADER, the new replica may have been added to the local membership, but ds_rsvc_add_replicas_s destroys it. This missing member may render the PS unavailable, especially after a rdb_dictate call.
This patch changes the error handling to destroy the new replica only if it hasn't been added the local membership. (We add it locally before adding it remotely.)
Steps for the author:
After all prior steps are complete: